helpers/mount: Check for failed umounts only umounting the whole list

[waydroid.git] / tools / helpers / mount.py

diff --git a/tools/helpers/mount.py b/tools/helpers/mount.py
index 4d772067fa76bcd152c6ec7053ef52ac8fecea0c..fce103567648072646289a045fd28548d6f0434d 100644 (file)
--- a/tools/helpers/mount.py
+++ b/tools/helpers/mount.py
@@ -37,13 +37,13 @@ def bind(args, source, destination, create_folders=True, umount=False):
         if os.path.exists(path):
             continue
         if create_folders:
         if os.path.exists(path):
             continue
         if create_folders:

-            tools.helpers.run.root(args, ["mkdir", "-p", path])
+            tools.helpers.run.user(args, ["mkdir", "-p", path])

         else:
             raise RuntimeError("Mount failed, folder does not exist: " +
                                path)
 
     # Actually mount the folder
         else:
             raise RuntimeError("Mount failed, folder does not exist: " +
                                path)
 
     # Actually mount the folder

-    tools.helpers.run.root(args, ["mount", "-o", "bind", source, destination])
+    tools.helpers.run.user(args, ["mount", "-o", "bind", source, destination])

 
     # Verify, that it has worked
     if not ismount(destination):
 
     # Verify, that it has worked
     if not ismount(destination):


@@ -64,12 +64,12 @@ def bind_file(args, source, destination, create_folders=False):
         if create_folders:
             dir = os.path.dirname(destination)
             if not os.path.isdir(dir):
         if create_folders:
             dir = os.path.dirname(destination)
             if not os.path.isdir(dir):

-                tools.helpers.run.root(args, ["mkdir", "-p", dir])
+                tools.helpers.run.user(args, ["mkdir", "-p", dir])

 
 

-        tools.helpers.run.root(args, ["touch", destination])
+        tools.helpers.run.user(args, ["touch", destination])

 
     # Mount
 
     # Mount

-    tools.helpers.run.root(args, ["mount", "-o", "bind", source,
+    tools.helpers.run.user(args, ["mount", "-o", "bind", source,

                                 destination])
 
 
                                 destination])
 
 


@@ -102,8 +102,10 @@ def umount_all(args, folder):
     """
     Umount all folders, that are mounted inside a given folder.
     """
     """
     Umount all folders, that are mounted inside a given folder.
     """

-    for mountpoint in umount_all_list(folder):
-        tools.helpers.run.root(args, ["umount", mountpoint])
+    all_list = umount_all_list(folder)
+    for mountpoint in all_list:
+        tools.helpers.run.user(args, ["umount", mountpoint])
+    for mountpoint in all_list:

         if ismount(mountpoint):
             raise RuntimeError("Failed to umount: " + mountpoint)
 
         if ismount(mountpoint):
             raise RuntimeError("Failed to umount: " + mountpoint)
 


@@ -122,15 +124,15 @@ def mount(args, source, destination, create_folders=True, umount=False, readonly
     # Check/create folders
     if not os.path.exists(destination):
         if create_folders:
     # Check/create folders
     if not os.path.exists(destination):
         if create_folders:

-            tools.helpers.run.root(args, ["mkdir", "-p", destination])
+            tools.helpers.run.user(args, ["mkdir", "-p", destination])

         else:
             raise RuntimeError("Mount failed, folder does not exist: " +
                             destination)
 
     # Actually mount the folder
         else:
             raise RuntimeError("Mount failed, folder does not exist: " +
                             destination)
 
     # Actually mount the folder

-    tools.helpers.run.root(args, ["mount", source, destination])
+    tools.helpers.run.user(args, ["mount", source, destination])

     if readonly:
     if readonly:

-        tools.helpers.run.root(args, ["mount", "-o", "remount,ro", source, destination])
+        tools.helpers.run.user(args, ["mount", "-o", "remount,ro", source, destination])

 
     # Verify, that it has worked
     if not ismount(destination):
 
     # Verify, that it has worked
     if not ismount(destination):