From: Loïc CORBASSON <loic.devel@corbasson.fr>
Date: Wed, 1 Nov 2023 12:43:18 +0000 (+0100)
Subject: Don't change user-defined desktop files for Waydroid when they're set as read-only
X-Git-Tag: 1.4.3~10
X-Git-Url: https://glassweightruler.freedombox.rocks/gitweb/waydroid.git/commitdiff_plain/3e6872c0fd97dd5463d07315548187ad16a1eda1

Don't change user-defined desktop files for Waydroid when they're set as read-only
---

diff --git a/tools/services/user_manager.py b/tools/services/user_manager.py
index 92ee203..83a50cc 100644
--- a/tools/services/user_manager.py
+++ b/tools/services/user_manager.py
@@ -49,10 +49,14 @@ Icon={waydroid_data}/icons/com.android.settings.png
 
     def makeWaydroidDesktopFile(hide):
         desktop_file_path = apps_dir + "/Waydroid.desktop"
-        if os.path.isfile(desktop_file_path):
-            os.remove(desktop_file_path)
-        with open(desktop_file_path, "w") as desktop_file:
-            desktop_file.write(f"""\
+        # If the user has set the desktop file as read-only, we won't replace it
+        if not os.access(desktop_file_path, os.W_OK):
+            logging.info(f"Desktop file '{desktop_file_path}' is not writeable, not updating it")
+        else:
+            if os.path.isfile(desktop_file_path):
+                os.remove(desktop_file_path)
+            with open(desktop_file_path, "w") as desktop_file:
+                desktop_file.write(f"""\
 [Desktop Entry]
 Type=Application
 Name=Waydroid